Skip to content

fix: Support rewriter. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: Support rewriter. #95

merged 1 commit into from
Oct 3, 2024

Conversation

DanCardin
Copy link
Owner

@DanCardin DanCardin commented Oct 3, 2024

Fixes #93

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11162003466

Details

  • 73 of 76 (96.05%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 91.011%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sqlalchemy_declarative_extensions/alembic/base.py 26 29 89.66%
Files with Coverage Reduction New Missed Lines %
src/sqlalchemy_declarative_extensions/alembic/schema.py 1 86.49%
src/sqlalchemy_declarative_extensions/alembic/database.py 2 47.83%
Totals Coverage Status
Change from base Build 11125246955: 0.06%
Covered Lines: 3461
Relevant Lines: 3757

💛 - Coveralls

@DanCardin DanCardin merged commit 2c329d8 into main Oct 3, 2024
17 checks passed
@DanCardin DanCardin deleted the dc/rewriter branch October 3, 2024 12:38
alex-ruehe added a commit to alex-ruehe/sqlalchemy-declarative-extensions that referenced this pull request Oct 7, 2024
Due to the recent changes introduced in DanCardin#95, it looks like alembic is now a requirement. Importing something like `from sqlalchemy_declarative_extensions import register_sqlalchemy_events` will now require alembic, which was not the case before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with alembic.autogenerate.rewriter.Rewriter
2 participants