Skip to content

Fixes #230 as cfn-lint now passes with no errors #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Fixes #230 as cfn-lint now passes with no errors #231

merged 1 commit into from
Mar 19, 2020

Conversation

flagscript
Copy link
Contributor

@flagscript flagscript commented Mar 18, 2020

What does this PR do?

This pull request allows template.yaml to successfully pass a cfn-lint check with no errors or warnings.

Motivation

It's typical in CodeBuild steps to perform cfn-lint on all CloudFormation templates before deployment. Currently, template.yaml is failing a cfn-lint check with an error and a warning:

> cfn-lint --template aws/logs_monitoring/template.yaml

W2510 Lambda Memory Size parameters should use MinValue, MaxValue or AllowedValues at Parameters/MemorySize
aws/logs_monitoring/template.yaml:22:3

E3012 Property Resources/Forwarder/Properties/Environment/Variables/DD_ENHANCED_METRICS should be of type String
aws/logs_monitoring/template.yaml:269:11

Additional Notes

Not relevant to this pull, but might be worth while in the future to replace aws cloudformation validate-template in release.sh with cfn-lint, as the former only validates that templates follow syntax, while the later will test for actual inconsistencies as well.

Checklist

  • Member of the datadog team has run integration tests

@tianchu tianchu merged commit a81458e into DataDog:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants