Skip to content

Update yaml files to add key parameter #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 8, 2018
Merged

Update yaml files to add key parameter #29

merged 4 commits into from
Mar 8, 2018

Conversation

DanielLanger
Copy link
Contributor

No description provided.

@garnermccloud
Copy link
Contributor

Files are missing newlines at the end but otherwise this looks good. Were you able to test with cloudformation?

@DanielLanger
Copy link
Contributor Author

Do they need newlines at the end? Don't see that previously.

And how did you test using cloudformation in the past?

@DanielLanger
Copy link
Contributor Author

Tested both YAML templates in demo aws account and both successfully created correct stack

@DanielLanger DanielLanger merged commit 4f3e6ab into master Mar 8, 2018
@tmichelet tmichelet deleted the daniel/samtemplateupdate branch March 9, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielLanger @garnermccloud