Skip to content

Rename custom tag #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

Rename custom tag #30

merged 1 commit into from
Mar 13, 2018

Conversation

DanielLanger
Copy link
Contributor

No description provided.

NBParis
NBParis approved these changes Mar 13, 2018
View reviewed changes
Copy link

@NBParis NBParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichelet
Copy link
Contributor

Why are we doing this?

@NBParis
Copy link

NBParis commented Mar 13, 2018

@tmichelet Basically, the tag functionname on metrics is referencing the lambda function that generate the metric.

Whereas here the functionname tag was always referencing the Lambda used to forward logs which could have led to confusion.

@tmichelet
Copy link
Contributor

ok

@DanielLanger DanielLanger merged commit 1b8fb3d into master Mar 13, 2018
@NBParis NBParis deleted the daniel/awslogfunction branch July 23, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NBParis NBParis NBParis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielLanger @tmichelet @NBParis