Skip to content

Fix encoding issue with SNS events #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

Fix encoding issue with SNS events #42

merged 1 commit into from
May 30, 2018

Conversation

NBParis
Copy link

@NBParis NBParis commented May 30, 2018

Sns logs now have the proper source.
And they are properly displayed in the plateform. The logs were badly encoded by the json.loads method.

@NBParis NBParis requested a review from a team May 30, 2018 14:30
ajacquemot
ajacquemot approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@ajacquemot ajacquemot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NBParis NBParis merged commit bf6cfe2 into master May 30, 2018
@NBParis NBParis deleted the nils/sns-encoding-fix branch May 30, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajacquemot ajacquemot ajacquemot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NBParis @ajacquemot