Skip to content

don't inject AspNetHttpModule automatically #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

lucaspimentel
Copy link
Member

Temporarily disable the AspNet integration that injects AspNetHttpModule. Users can add it manually for testing.

@lucaspimentel lucaspimentel added the area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) label Mar 11, 2019
@lucaspimentel lucaspimentel added this to the 0.8.0-beta milestone Mar 11, 2019
@lucaspimentel lucaspimentel self-assigned this Mar 11, 2019
@lucaspimentel lucaspimentel requested a review from a team as a code owner March 11, 2019 22:48
[InterceptMethod(
TargetAssembly = "System.Web",
TargetType = "System.Web.HttpApplication")]
// [InterceptMethod(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just delete instead of comment out? Git history, can always get this back.

@lucaspimentel lucaspimentel merged commit ba2c208 into develop Mar 11, 2019
@lucaspimentel lucaspimentel deleted the lpimentel/disable-aspnet branch March 11, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants