Skip to content

allow users to set sampling priority #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix xml doc comments
  • Loading branch information
lucaspimentel committed Apr 4, 2019
commit 5468578b6cb0ea5a8e44e6bbadf2e9301c8abc94
20 changes: 10 additions & 10 deletions src/Datadog.Trace/Span.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Collections.Concurrent;
using System.Text;
using Datadog.Trace.ExtensionMethods;
using Datadog.Trace.Interfaces;
using Datadog.Trace.Logging;

Expand Down Expand Up @@ -123,11 +124,11 @@ public override string ToString()
}

/// <summary>
/// Add a tag metadata to the span
/// Add a the specified tag to this span.
/// </summary>
/// <param name="key">The tag's key</param>
/// <param name="value">The tag's value</param>
/// <returns> The span object itself</returns>
/// <param name="key">The tag's key.</param>
/// <param name="value">The tag's value.</param>
/// <returns>This span to allow method chaining.</returns>
public Span SetTag(string key, string value)
{
if (IsFinished)
Expand Down Expand Up @@ -166,20 +167,19 @@ public Span SetTag(string key, string value)
break;
default:
// if not a special tag, just add it to the tag bag
Tags[key] = value;
Tags[key] = value;
break;
}

return this;
}

/// <summary>
/// Proxy to SetTag without return value
/// See <see cref="Span.SetTag(string, string)"/> for more information
/// Add a the specified tag to this span.
/// </summary>
/// <param name="key">The tag's key</param>
/// <param name="value">The tag's value</param>
/// <returns> The ISpan object itself</returns>
/// <param name="key">The tag's key.</param>
/// <param name="value">The tag's value.</param>
/// <returns>This span to allow method chaining.</returns>
ISpan ISpan.SetTag(string key, string value)
=> SetTag(key, value);

Expand Down