-
Notifications
You must be signed in to change notification settings - Fork 300
Extended appsec request body collection #8748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jandro996
wants to merge
3
commits into
alejandro.gonzalez/WaPo-headers
Choose a base branch
from
alejandro.gonzalez/WaPo-request-body
base: alejandro.gonzalez/WaPo-headers
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Extended appsec request body collection #8748
jandro996
wants to merge
3
commits into
alejandro.gonzalez/WaPo-headers
from
alejandro.gonzalez/WaPo-request-body
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027315
Total [baseline] (8.678 s) : 0, 8678183
Agent [candidate] (1.005 s) : 0, 1005036
Total [candidate] (8.614 s) : 0, 8613766
section iast
Agent [baseline] (1.146 s) : 0, 1146279
Total [baseline] (9.245 s) : 0, 9245052
Agent [candidate] (1.152 s) : 0, 1152299
Total [candidate] (9.259 s) : 0, 9259120
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.144 s) : 0, 1144424
Total [baseline] (9.215 s) : 0, 9214611
Agent [candidate] (1.136 s) : 0, 1136356
Total [candidate] (9.182 s) : 0, 9182213
section iast_TELEMETRY_OFF
Agent [baseline] (1.16 s) : 0, 1159849
Total [baseline] (9.287 s) : 0, 9286537
Agent [candidate] (1.134 s) : 0, 1133909
Total [candidate] (9.181 s) : 0, 9180771
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.819 ms) : 0, 685819
BytebuddyAgent [candidate] (669.555 ms) : 0, 669555
GlobalTracer [baseline] (241.076 ms) : 0, 241076
GlobalTracer [candidate] (239.353 ms) : 0, 239353
AppSec [baseline] (54.908 ms) : 0, 54908
AppSec [candidate] (54.655 ms) : 0, 54655
Debugger [baseline] (9.121 ms) : 0, 9121
Debugger [candidate] (7.515 ms) : 0, 7515
Remote Config [baseline] (700.983 µs) : 0, 701
Remote Config [candidate] (691.633 µs) : 0, 692
Telemetry [baseline] (12.118 ms) : 0, 12118
Telemetry [candidate] (9.785 ms) : 0, 9785
section iast
BytebuddyAgent [baseline] (800.387 ms) : 0, 800387
BytebuddyAgent [candidate] (801.137 ms) : 0, 801137
GlobalTracer [baseline] (229.859 ms) : 0, 229859
GlobalTracer [candidate] (232.66 ms) : 0, 232660
AppSec [baseline] (50.234 ms) : 0, 50234
AppSec [candidate] (57.119 ms) : 0, 57119
Debugger [baseline] (5.865 ms) : 0, 5865
Debugger [candidate] (6.007 ms) : 0, 6007
Remote Config [baseline] (587.936 µs) : 0, 588
Remote Config [candidate] (598.547 µs) : 0, 599
Telemetry [baseline] (7.756 ms) : 0, 7756
Telemetry [candidate] (7.987 ms) : 0, 7987
IAST [baseline] (28.177 ms) : 0, 28177
IAST [candidate] (23.089 ms) : 0, 23089
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.371 ms) : 0, 798371
BytebuddyAgent [candidate] (788.937 ms) : 0, 788937
GlobalTracer [baseline] (229.974 ms) : 0, 229974
GlobalTracer [candidate] (230.128 ms) : 0, 230128
AppSec [baseline] (48.311 ms) : 0, 48311
AppSec [candidate] (56.555 ms) : 0, 56555
Debugger [baseline] (5.869 ms) : 0, 5869
Debugger [candidate] (5.871 ms) : 0, 5871
Remote Config [baseline] (582.448 µs) : 0, 582
Remote Config [candidate] (585.284 µs) : 0, 585
Telemetry [baseline] (7.864 ms) : 0, 7864
Telemetry [candidate] (7.898 ms) : 0, 7898
IAST [baseline] (30.108 ms) : 0, 30108
IAST [candidate] (22.884 ms) : 0, 22884
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.393 ms) : 0, 809393
BytebuddyAgent [candidate] (786.966 ms) : 0, 786966
GlobalTracer [baseline] (232.856 ms) : 0, 232856
GlobalTracer [candidate] (230.097 ms) : 0, 230097
AppSec [baseline] (54.282 ms) : 0, 54282
AppSec [candidate] (56.563 ms) : 0, 56563
Debugger [baseline] (6.031 ms) : 0, 6031
Debugger [candidate] (5.963 ms) : 0, 5963
Remote Config [baseline] (623.406 µs) : 0, 623
Remote Config [candidate] (591.248 µs) : 0, 591
Telemetry [baseline] (7.922 ms) : 0, 7922
Telemetry [candidate] (7.758 ms) : 0, 7758
IAST [baseline] (25.059 ms) : 0, 25059
IAST [candidate] (22.582 ms) : 0, 22582
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018869
Total [baseline] (10.433 s) : 0, 10433159
Agent [candidate] (1.012 s) : 0, 1012291
Total [candidate] (10.479 s) : 0, 10478925
section appsec
Agent [baseline] (1.161 s) : 0, 1161355
Total [baseline] (10.69 s) : 0, 10689846
Agent [candidate] (1.156 s) : 0, 1156018
Total [candidate] (10.682 s) : 0, 10681704
section iast
Agent [baseline] (1.148 s) : 0, 1147943
Total [baseline] (10.864 s) : 0, 10864436
Agent [candidate] (1.135 s) : 0, 1134639
Total [candidate] (10.752 s) : 0, 10751992
section profiling
Agent [baseline] (1.283 s) : 0, 1283125
Total [baseline] (10.782 s) : 0, 10781687
Agent [candidate] (1.255 s) : 0, 1255253
Total [candidate] (10.778 s) : 0, 10777741
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.235 ms) : 0, 682235
BytebuddyAgent [candidate] (675.245 ms) : 0, 675245
GlobalTracer [baseline] (239.41 ms) : 0, 239410
GlobalTracer [candidate] (241.531 ms) : 0, 241531
AppSec [baseline] (55.12 ms) : 0, 55120
AppSec [candidate] (55.134 ms) : 0, 55134
Debugger [baseline] (9.0 ms) : 0, 9000
Debugger [candidate] (6.225 ms) : 0, 6225
Remote Config [baseline] (669.811 µs) : 0, 670
Remote Config [candidate] (708.876 µs) : 0, 709
Telemetry [baseline] (8.937 ms) : 0, 8937
Telemetry [candidate] (9.899 ms) : 0, 9899
section appsec
BytebuddyAgent [baseline] (700.559 ms) : 0, 700559
BytebuddyAgent [candidate] (692.826 ms) : 0, 692826
GlobalTracer [baseline] (236.756 ms) : 0, 236756
GlobalTracer [candidate] (237.993 ms) : 0, 237993
AppSec [baseline] (175.367 ms) : 0, 175367
AppSec [candidate] (176.263 ms) : 0, 176263
Debugger [baseline] (5.963 ms) : 0, 5963
Debugger [candidate] (5.916 ms) : 0, 5916
Remote Config [baseline] (619.918 µs) : 0, 620
Remote Config [candidate] (642.627 µs) : 0, 643
Telemetry [baseline] (7.808 ms) : 0, 7808
Telemetry [candidate] (7.806 ms) : 0, 7806
IAST [baseline] (21.582 ms) : 0, 21582
IAST [candidate] (22.089 ms) : 0, 22089
section iast
BytebuddyAgent [baseline] (801.844 ms) : 0, 801844
BytebuddyAgent [candidate] (789.036 ms) : 0, 789036
GlobalTracer [baseline] (230.229 ms) : 0, 230229
GlobalTracer [candidate] (229.609 ms) : 0, 229609
AppSec [baseline] (49.232 ms) : 0, 49232
AppSec [candidate] (55.708 ms) : 0, 55708
Debugger [baseline] (5.862 ms) : 0, 5862
Debugger [candidate] (5.814 ms) : 0, 5814
Remote Config [baseline] (584.243 µs) : 0, 584
Remote Config [candidate] (580.293 µs) : 0, 580
Telemetry [baseline] (7.768 ms) : 0, 7768
Telemetry [candidate] (7.817 ms) : 0, 7817
IAST [baseline] (27.414 ms) : 0, 27414
IAST [candidate] (22.636 ms) : 0, 22636
section profiling
BytebuddyAgent [baseline] (673.964 ms) : 0, 673964
BytebuddyAgent [candidate] (661.689 ms) : 0, 661689
GlobalTracer [baseline] (378.721 ms) : 0, 378721
GlobalTracer [candidate] (378.299 ms) : 0, 378299
AppSec [baseline] (55.056 ms) : 0, 55056
AppSec [candidate] (54.106 ms) : 0, 54106
Debugger [baseline] (6.176 ms) : 0, 6176
Debugger [candidate] (6.143 ms) : 0, 6143
Remote Config [baseline] (667.474 µs) : 0, 667
Remote Config [candidate] (658.119 µs) : 0, 658
Telemetry [baseline] (8.12 ms) : 0, 8120
Telemetry [candidate] (8.174 ms) : 0, 8174
ProfilingAgent [baseline] (109.969 ms) : 0, 109969
ProfilingAgent [candidate] (96.019 ms) : 0, 96019
Profiling [baseline] (109.994 ms) : 0, 109994
Profiling [candidate] (96.043 ms) : 0, 96043
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1386
. : milestone, 1365,
appsec (1.732 ms) : 1708, 1755
. : milestone, 1732,
appsec_no_iast (1.708 ms) : 1684, 1732
. : milestone, 1708,
code_origins (1.665 ms) : 1638, 1692
. : milestone, 1665,
iast (1.52 ms) : 1496, 1544
. : milestone, 1520,
profiling (1.512 ms) : 1488, 1535
. : milestone, 1512,
tracing (1.49 ms) : 1466, 1513
. : milestone, 1490,
section candidate
no_agent (1.37 ms) : 1351, 1389
. : milestone, 1370,
appsec (1.714 ms) : 1690, 1737
. : milestone, 1714,
appsec_no_iast (1.712 ms) : 1688, 1736
. : milestone, 1712,
code_origins (1.679 ms) : 1651, 1707
. : milestone, 1679,
iast (1.506 ms) : 1481, 1531
. : milestone, 1506,
profiling (1.513 ms) : 1487, 1538
. : milestone, 1513,
tracing (1.461 ms) : 1436, 1486
. : milestone, 1461,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section baseline
no_agent (373.946 µs) : 354, 394
. : milestone, 374,
iast (526.808 µs) : 503, 550
. : milestone, 527,
iast_FULL (730.29 µs) : 709, 752
. : milestone, 730,
iast_GLOBAL (555.748 µs) : 534, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (515.183 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (475.083 µs) : 450, 500
. : milestone, 475,
iast_TELEMETRY_OFF (508.469 µs) : 485, 532
. : milestone, 508,
tracing (457.834 µs) : 435, 480
. : milestone, 458,
section candidate
no_agent (382.044 µs) : 362, 402
. : milestone, 382,
iast (522.727 µs) : 500, 546
. : milestone, 523,
iast_FULL (726.516 µs) : 703, 750
. : milestone, 727,
iast_GLOBAL (566.019 µs) : 541, 591
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (521.912 µs) : 499, 545
. : milestone, 522,
iast_INACTIVE (466.357 µs) : 444, 489
. : milestone, 466,
iast_TELEMETRY_OFF (509.49 µs) : 486, 533
. : milestone, 509,
tracing (450.841 µs) : 428, 474
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.425 ms) : 2375, 2474
. : milestone, 2425,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.248 ms) : 2185, 2311
. : milestone, 2248,
profiling (2.062 ms) : 2011, 2113
. : milestone, 2062,
tracing (2.029 ms) : 1980, 2078
. : milestone, 2029,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.431 ms) : 2381, 2480
. : milestone, 2431,
iast (2.199 ms) : 2136, 2261
. : milestone, 2199,
iast_GLOBAL (2.236 ms) : 2174, 2299
. : milestone, 2236,
profiling (2.055 ms) : 2004, 2106
. : milestone, 2055,
tracing (2.037 ms) : 1988, 2086
. : milestone, 2037,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~5067ac7755, baseline=1.50.0-SNAPSHOT~d8111df5c7
dateFormat X
axisFormat %s
section baseline
no_agent (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
appsec (15.115 s) : 15115000, 15115000
. : milestone, 15115000,
iast (18.742 s) : 18742000, 18742000
. : milestone, 18742000,
iast_GLOBAL (17.843 s) : 17843000, 17843000
. : milestone, 17843000,
profiling (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
tracing (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
section candidate
no_agent (15.465 s) : 15465000, 15465000
. : milestone, 15465000,
appsec (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
iast (18.985 s) : 18985000, 18985000
. : milestone, 18985000,
iast_GLOBAL (18.284 s) : 18284000, 18284000
. : milestone, 18284000,
profiling (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
tracing (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
|
dc48fa1
to
761eade
Compare
bdc855c
to
5dcd1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds the
APPSEC_RASP_COLLECT_REQUEST_BODY
flag, which enables collection of request body. This feature is disabled by default.if
APPSEC_RASP_COLLECT_REQUEST_BODY
is enabled and there is a RASP event put the same parsed request body that is sent to the WAF viameta_struct
withhttp.request.body
keyAdd limits to maximun size String in ObjectIntrospection, if a limit is surpassed boolean tag
_dd.appsec.rasp.request_body_size.exceeded
is addedMotivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57268