-
Notifications
You must be signed in to change notification settings - Fork 468
fix: fix the python detector regex + tests [backport 3.17] #15078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## Description - Fix the Python Detector regex so it also detects paths ending with the major version number (/foo/bar/python3). - Use `re.compile`. - Add tests. ## Testing - Add a new test for positive and negative matches of the Python Detector. --------- Signed-off-by: Juanjo Alvarez <[email protected]> (cherry picked from commit 2a69e20) Signed-off-by: Juanjo Alvarez <[email protected]>
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 242 ± 6 ms. The average import time from base is: 247 ± 6 ms. The import time difference between this PR and base is: -4.8 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
f612676 to
def5c97
Compare
Performance SLOsComparing candidate backport-15068-to-3.17 (def5c97) with baseline 3.17 (58542d4) 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.429ms (SLO: <22.300ms -8.4%) vs baseline: -0.2% Memory: ✅ 65.402MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.2%) vs baseline: ~same Memory: ✅ 64.527MB (SLO: <67.000MB -3.7%) vs baseline: +4.9% ✅ iastTime: ✅ 20.471ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 65.483MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.270ms (SLO: <16.550ms -7.7%) vs baseline: +0.4% Memory: ✅ 53.870MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 20.527ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 65.334MB (SLO: <67.000MB -2.5%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 25.396ms (SLO: <28.200ms -9.9%) vs baseline: -0.2% Memory: ✅ 67.537MB (SLO: <69.500MB -2.8%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.509ms (SLO: <21.750ms -5.7%) vs baseline: +0.1% Memory: ✅ 65.450MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 21.948ms (SLO: <23.500ms -6.6%) vs baseline: -0.2% Memory: ✅ 66.503MB (SLO: <67.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ tracer-dont-create-db-spansTime: ✅ 19.282ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.1% Memory: ✅ 65.490MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.1% ✅ tracer-minimalTime: ✅ 16.570ms (SLO: <17.500ms -5.3%) vs baseline: -0.2% Memory: ✅ 65.444MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.415ms (SLO: <21.750ms -6.1%) vs baseline: ~same Memory: ✅ 71.462MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.455ms (SLO: <19.650ms -6.1%) vs baseline: -0.1% Memory: ✅ 65.425MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.814ms (SLO: <20.100ms -6.4%) vs baseline: ~same Memory: ✅ 65.125MB (SLO: <67.000MB -2.8%) vs baseline: +4.4% ✅ tracer-no-middlewareTime: ✅ 20.137ms (SLO: <21.500ms -6.3%) vs baseline: +0.2% Memory: ✅ 65.401MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.308ms (SLO: <22.000ms -7.7%) vs baseline: +0.2% Memory: ✅ 65.469MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.301ms (SLO: <19.850ms -7.8%) vs baseline: +1.1% Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.051ms (SLO: <19.400ms -7.0%) vs baseline: -0.3% Memory: ✅ 65.246MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.028ms (SLO: <19.450ms -7.3%) vs baseline: +0.1% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: +0.2% Memory: ✅ 61.835MB (SLO: <65.000MB -4.9%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.594ms (SLO: <6.750ms -2.3%) vs baseline: ~same Memory: ✅ 62.136MB (SLO: <65.000MB -4.4%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.577ms (SLO: <4.750ms -3.6%) vs baseline: -0.4% Memory: ✅ 61.856MB (SLO: <65.000MB -4.8%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: +0.1% Memory: ✅ 45.436MB (SLO: <47.000MB -3.3%) vs baseline: +4.5% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 42.408MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.448MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: +0.2% Memory: ✅ 52.418MB (SLO: <53.500MB -2.0%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 52.180MB (SLO: <53.500MB -2.5%) vs baseline: +4.5% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 58.182MB (SLO: <60.000MB -3.0%) vs baseline: +4.6% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.959µs (SLO: <20.000µs 📉 -85.2%) vs baseline: +0.7% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 204.323µs (SLO: <220.000µs -7.1%) vs baseline: +0.2% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.326µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +1.1% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.221µs (SLO: <220.000µs 🟡 -1.7%) vs baseline: +0.3% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.273µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +4.5% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.703µs (SLO: <150.000µs -7.5%) vs baseline: +1.6% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.099µs (SLO: <20.000µs 📉 -84.5%) vs baseline: +1.1% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 217.723µs (SLO: <250.000µs 📉 -12.9%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.474ms (SLO: <22.000ms -6.9%) vs baseline: -1.9% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.284ms (SLO: <2.300ms 🟡 -0.7%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.426ms (SLO: <1.550ms -8.0%) vs baseline: +0.8% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.4% ✅ 100-rate-metrics-100-timesTime: ✅ 2.239ms (SLO: <2.550ms 📉 -12.2%) vs baseline: -1.0% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +4.2% ✅ flush-1-metricTime: ✅ 4.524µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +0.7% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 175.465µs (SLO: <250.000µs 📉 -29.8%) vs baseline: ~same Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.151ms (SLO: <2.500ms 📉 -14.0%) vs baseline: +1.0% Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +5.0%
|
Backport 2a69e20 from #15068 to 3.17.
Description
re.compile.Testing