Skip to content

Implement KuCoin orderbook WebSocket listener #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use maxCount param value instead of hardcoded 100
  • Loading branch information
v36u committed Feb 4, 2024
commit 57e9d97e7cb733a299a28f2b987a3908554f5cae
4 changes: 2 additions & 2 deletions src/ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ private async Task<List<string>> GetMarketSymbolList(string[] marketSymbols)
/// <returns></returns>
protected override async Task<IWebSocket> OnGetDeltaOrderBookWebSocketAsync(
Action<ExchangeOrderBook> callback,
int maxCount = 20,
int maxCount = 100,
params string[] marketSymbols
)
{
Expand Down Expand Up @@ -1639,7 +1639,7 @@ params string[] marketSymbols
{
Event = ActionType.Subscribe,
Pairs = marketSymbols.ToList(),
SubscriptionSettings = new Subscription { Name = "book", Depth = 100 }
SubscriptionSettings = new Subscription { Name = "book", Depth = maxCount }
};
await _socket.SendMessageAsync(channelAction);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public static class ExchangeAPIExtensions
public static async Task<IWebSocket> GetFullOrderBookWebSocketAsync(
this IOrderBookProvider api,
Action<ExchangeOrderBook> callback,
int maxCount = 20,
int maxCount = 100,
params string[] symbols
)
{
Expand Down