Skip to content

added pseudo apiSecureStorage keyword to get async keychain values #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2025

Conversation

M-Taha-Dev
Copy link
Contributor

Added logic to handle pseudo apiSecureStorage keyword to fetch async values from Keychain manager. The scope of this keyword is in API only.
Sample EDL:
image

Copy link
Contributor

@vusters vusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hacky and the wrong approach. What you can do is to use the same exact evaluate() function that we used everywhere. The key is to inject the secureStorageMap into the payload IF this is an API call. You should not have to do anything else extra.

@M-Taha-Dev M-Taha-Dev requested a review from vusters June 3, 2025 00:20
Copy link
Contributor

@vusters vusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good.

@M-Taha-Dev M-Taha-Dev merged commit 71f37d8 into main Jun 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants