Skip to content

Fix errors and warnings from astro check. #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix YouTube types.
  • Loading branch information
nikoshell committed May 5, 2025
commit 3d767e0fae27b0b1bf8e66730400640b44fb7be9
4 changes: 3 additions & 1 deletion src/components/ui/YouTube.astro
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ const {
...attrs
} = Astro.props;

const attrId = attrs.id || '';

const defaultClass = 'border-4 border-white rounded-lg shadow-lg';
const className = `${defaultClass} ${userClass}`.trim();
---

<Player:Props class={className} {...attrs} />
<Player id={attrId} class={className} {...attrs} />
1 change: 0 additions & 1 deletion src/layouts/ScheduleLayout.astro
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
import Layout from "@layouts/Layout.astro";
import Headline from "@ui/Headline.astro";
import Section from "@ui/Section.astro";

export interface Props {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/media/card/[slug].astro
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
import { getCollection, getEntries, type CollectionEntry } from "astro:content";
import { getCollection} from "astro:content";
import SocialMediaCard from "@components/SocialMediaCard.astro";

export async function getStaticPaths() {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/schedule.astro
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
import { getEntry, getCollection } from "astro:content";
import { getCollection } from "astro:content";
import Layout from "@layouts/ScheduleLayout.astro";
import ScheduleDay from "@components/schedule/day.astro";

Expand Down
2 changes: 1 addition & 1 deletion src/pages/schedule/talks.astro
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
import { type CollectionEntry, getCollection } from "astro:content";
import { getCollection } from "astro:content";
import Layout from "@layouts/ScheduleLayout.astro";
import ScheduleDay from "@components/schedule/day.astro";
import { slugify } from '@utils/content';
Expand Down
1 change: 0 additions & 1 deletion src/pages/schedule/tutorials.astro
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { getCollection } from "astro:content";
import Layout from "@layouts/ScheduleLayout.astro";
import ScheduleDay from "@components/schedule/day.astro";
import { slugify } from '@utils/content';
import Headline from "@ui/Headline.astro"

export const getStaticPaths = async () => {
const sessions = await getCollection("sessions");
Expand Down
2 changes: 1 addition & 1 deletion src/pages/speakers.astro
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const description = "Our conference speakers organized alphabetically";
</Prose>

{
groupKeys.map((key, index) => (
groupKeys.map((key, _index) => (
<>
<div id={`group-${key}`} class="pt-6">
<div class="grid grid-cols-2 sm:grid-cols-3 md:grid-cols-4 lg:grid-cols-5 gap-6 mb-10">
Expand Down
2 changes: 1 addition & 1 deletion src/utils/content.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export function slugify(text) {
export function slugify(text: string): string {
return text
.toString()
.toLowerCase()
Expand Down