[plugin] change tasks HttpClient engine from CIO to Apache #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
added
changes: patch
dariuszkuc
changed the title
|
Ugh forgot that we build and release using Java 8... that new HttpClient is available from Java 11. I'll update the PR to use other engine. |
dariuszkuc
changed the title
dariuszkuc
changed the title
It looks like using CIO engine causes some issues with the classpath (ExpediaGroup#1084). Unsure what is the root cause of the classpath issue - it looks like CIO engine relies on coroutines-core `native-mt` vs regular artifact that we pull in. Switching to a different engine seems to resolve the classpath issue.
smyrick
approved these changes
May 26, 2021
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…#1162) It looks like using CIO engine causes some issues with the classpath (ExpediaGroup#1084). Unsure what is the root cause of the classpath issue - it looks like CIO engine relies on coroutines-core `native-mt` vs regular artifact that we pull in. Switching to a different engine seems to resolve the classpath issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
It looks like using CIO engine causes some issues with the classpath (#1084). Unsure what is the root cause of the classpath issue - it looks like CIO engine relies on coroutines-core
native-mtvs regular artifact that we pull in. Switching to a different engine seems to resolve the classpath issue.🔗 Related Issues
Resolves: #1084