Skip to content

fix: description of parameters #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2018
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Dec 27, 2018

The graphql description was supposed to fall back to the description of the type of the argument if there was none. This was not working as we have to fall back to the KClass first.

Also I added more unit tests for getting the list type and array type and simplified the directives adding to state

The graphql description was supposed to fall back to the description of the type of the argument if there was none. This was not working as we have to fall back to the KClass first.
@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #118 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
+ Coverage     90.07%   90.25%   +0.17%     
  Complexity      155      155              
============================================
  Files            47       47              
  Lines           504      503       -1     
  Branches        116      114       -2     
============================================
  Hits            454      454              
  Misses           10       10              
+ Partials         40       39       -1
Impacted Files Coverage Δ Complexity Δ
...pedia/graphql/generator/types/ObjectTypeBuilder.kt 94.73% <ø> (-0.27%) 2 <0> (ø)
...dia/graphql/generator/types/PropertyTypeBuilder.kt 68.42% <ø> (-1.58%) 6 <0> (ø)
...a/graphql/generator/extensions/kClassExtensions.kt 100% <100%> (+7.14%) 0 <0> (ø) ⬇️
...aphql/generator/extensions/kParameterExtensions.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...dia/graphql/generator/types/FunctionTypeBuilder.kt 77.41% <100%> (-0.71%) 8 <3> (ø)
...n/com/expedia/graphql/generator/SchemaGenerator.kt 100% <100%> (ø) 27 <2> (ø) ⬇️
...in/kotlin/com/expedia/graphql/TopLevelObjectDef.kt
.../main/kotlin/com/expedia/graphql/TopLevelObject.kt 100% <0%> (ø) 1% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1b189...6f26060. Read the comment docs.

@brennantaylor brennantaylor merged commit 4571cfd into ExpediaGroup:master Dec 27, 2018
@smyrick smyrick deleted the cleanup branch December 27, 2018 22:17
@smyrick smyrick added the changes: patch Changes require a patch version label Dec 29, 2018
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version
Development

Successfully merging this pull request may close these issues.

3 participants