[generator] add runtime warning on deprecated context usage #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates `FunctionDataFetcher` so that it logs a warning when injecting a `GraphQLContext`. This functionality is [deprecated](https://github.com/ExpediaGroup/graphql-kotlin/blob/master/website/docs/schema-generator/execution/contextual-data.md#interface-injection-deprecated). Unlike the `GraphQLContext` interface itself, which is annotated `@deprecated, there is no compile or runtime time warning when using `GraphQLContext` interface injection in a query or mutation. Related: * discussion: ExpediaGroup#1305 * supersedes: ExpediaGroup#1306
dariuszkuc
added
changes: patch
tapaderster
approved these changes
Dec 9, 2021
Samjin
approved these changes
Dec 9, 2021
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…roup#1323) ### 📝 Description This PR updates `FunctionDataFetcher` so that it logs a warning when injecting a `GraphQLContext`. This functionality is [deprecated](https://github.com/ExpediaGroup/graphql-kotlin/blob/master/website/docs/schema-generator/execution/contextual-data.md#interface-injection-deprecated). Unlike the `GraphQLContext` interface itself, which is annotated `@deprecated, there is no compile or runtime time warning when using `GraphQLContext` interface injection in a query or mutation. ### 🔗 Related Issues * discussion: ExpediaGroup#1305 * supersedes: ExpediaGroup#1306 Co-authored-by: Joel Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates
FunctionDataFetcherso that it logs a warning when injecting aGraphQLContext. This functionality is deprecated. Unlike theGraphQLContextinterface itself, which is annotated@deprecated, there is no compile or runtime time warning when usingGraphQLContext` interface injection in a query or mutation.🔗 Related Issues