Skip to content

[generator] avoid duplicate argument deserialization #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 8, 2022
Merged

[generator] avoid duplicate argument deserialization #1379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a719794
WIP: Copy issue to example
Sep 3, 2021
b2e0b69
Convert input to Kotlin without jackson
Sep 3, 2021
78418a7
Fix argument custom names issue
Sep 7, 2021
e7de366
Add unit test for optionalinput list
Sep 8, 2021
7a85c2e
Handle enum arguments
rocketraman Feb 17, 2022
3839bbd
[wip] drop jackson dependency from generator
Feb 26, 2022
effbb49
support inline classes
Feb 26, 2022
16f2fde
build fix
Feb 26, 2022
9613c55
drop usage of arrays from examples
Feb 27, 2022
e6c69ce
fix examples - missed files
Feb 27, 2022
21d1701
ktlint fix
Feb 27, 2022
721b053
update input object validation to verify it has a public primary cons…
Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build fix
  • Loading branch information
Dariusz Kuc committed Feb 26, 2022
commit 16f2fdeed01af72e2338f9daad106a0bbc2f7bab
40 changes: 0 additions & 40 deletions ...c/main/kotlin/com/expediagroup/graphql/server/spring/execution/OptionalInputSerializer.kt
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions ...-server/src/test/kotlin/com/expediagroup/graphql/server/spring/SchemaConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2021 Expedia, Inc
* Copyright 2022 Expedia, Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -20,7 +20,6 @@ import com.expediagroup.graphql.generator.SchemaGeneratorConfig
import com.expediagroup.graphql.generator.TopLevelObject
import com.expediagroup.graphql.generator.annotations.GraphQLDescription
import com.expediagroup.graphql.generator.execution.KotlinDataFetcherFactoryProvider
import com.expediagroup.graphql.generator.execution.SimpleKotlinDataFetcherFactoryProvider
import com.expediagroup.graphql.generator.toSchema
import com.expediagroup.graphql.server.execution.DataLoaderRegistryFactory
import com.expediagroup.graphql.server.execution.GraphQLContextFactory
Expand Down Expand Up @@ -68,11 +67,6 @@ class SchemaConfigurationTest {
assertThat(ctx).hasSingleBean(ObjectMapper::class.java)
val mapper = ctx.getBean(ObjectMapper::class.java)
assertThat(ctx).hasSingleBean(KotlinDataFetcherFactoryProvider::class.java)
val dataFetcherFactoryProvider = ctx.getBean(KotlinDataFetcherFactoryProvider::class.java)
val privateMapperField = SimpleKotlinDataFetcherFactoryProvider::class.java.getDeclaredField("objectMapper")
privateMapperField.isAccessible = true
val privateMapper = privateMapperField.get(dataFetcherFactoryProvider)
assertEquals(mapper, privateMapper)

assertThat(ctx).hasSingleBean(GraphQLSchema::class.java)
val schema = ctx.getBean(GraphQLSchema::class.java)
Expand Down