Skip to content

chore: tests for batching and deduplication by field selection #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 2, 2022
Merged

chore: tests for batching and deduplication by field selection #1449

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4ec8f7c
feat: support chained dataloaders
May 3, 2022
44a3640
feat: unused code
May 3, 2022
396765f
feat: renaming some fields and methods
May 4, 2022
eadd1d9
feat: renaming some fields and methods
May 4, 2022
1758f9c
feat: update coverage bc decorated methods
May 4, 2022
437bba8
fix: KotlinDataLoaderegistry
May 10, 2022
c5d8a58
fix: KotlinDataLoader test
May 10, 2022
748f90b
fix: KotlinDataLoader test
May 10, 2022
1a7cc50
feat: add copyright
May 11, 2022
39b2b56
feat: add removed files
May 11, 2022
09f7251
feat: update docs
May 16, 2022
6035002
feat: example of batching by selection fields
May 17, 2022
19b3e87
feat: add 1 more test
May 17, 2022
a310fd1
feat: add 1 more test
May 17, 2022
c32795e
feat: updade docs
May 19, 2022
da04f90
feat: update test
May 25, 2022
8364b40
feat: test case for batching by selection fields
May 27, 2022
e9074fe
chore: pull docs
May 27, 2022
9f52b30
feat: update tests
May 27, 2022
fb2b796
feat: update tests
May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: KotlinDataLoaderegistry
  • Loading branch information
samvazquez committed May 10, 2022
commit 437bba88a8ee60cc19bb69fccedabdc331940414
18 changes: 8 additions & 10 deletions ...oader/src/test/kotlin/com/expediagroup/graphql/dataloader/KotlinDataLoaderRegistryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.expediagroup.graphql.dataloader

import io.mockk.spyk
import org.dataloader.BatchLoader
import org.junit.jupiter.api.Test
import reactor.kotlin.core.publisher.toFlux
Expand All @@ -31,22 +30,20 @@ class KotlinDataLoaderRegistryTest {
val stringToUpperCaseDataLoader: KotlinDataLoader<String, String> = object : KotlinDataLoader<String, String> {
override val dataLoaderName: String = "ToUppercaseDataLoader"
override fun getBatchLoader(): BatchLoader<String, String> = BatchLoader<String, String> { keys ->
keys.toFlux().map(String::uppercase).collectList().delayElement(Duration.ofMillis(100)).toFuture()
keys.toFlux().map(String::uppercase).collectList().delayElement(Duration.ofMillis(400)).toFuture()
}
}

val stringToLowerCaseDataLoader: KotlinDataLoader<String, String> = object : KotlinDataLoader<String, String> {
override val dataLoaderName: String = "ToLowercaseDataLoader"
override fun getBatchLoader(): BatchLoader<String, String> = BatchLoader<String, String> { keys ->
keys.toFlux().map(String::lowercase).collectList().delayElement(Duration.ofMillis(300)).toFuture()
keys.toFlux().map(String::lowercase).collectList().delayElement(Duration.ofMillis(400)).toFuture()
}
}

val registry = spyk(
KotlinDataLoaderRegistryFactory(
stringToUpperCaseDataLoader, stringToLowerCaseDataLoader
).generate()
)
val registry = KotlinDataLoaderRegistryFactory(
stringToUpperCaseDataLoader, stringToLowerCaseDataLoader
).generate()

registry.getDataLoader<String, String>("ToUppercaseDataLoader").load("touppercase1").handle { _, _ -> }
registry.getDataLoader<String, String>("ToUppercaseDataLoader").load("touppercase2").handle { _, _ -> }
Expand All @@ -56,15 +53,16 @@ class KotlinDataLoaderRegistryTest {
registry.getDataLoader<String, String>("ToLowercaseDataLoader").load("TOLOWERCASE2").handle { _, _ -> }
registry.getDataLoader<String, String>("ToLowercaseDataLoader").load("TOLOWERCASE1").handle { _, _ -> }

registry.dispatchAll()
val futuresToComplete = registry.getOnDispatchFutures()
val futuresToComplete = registry.getCurrentFutures()
assertEquals(4, futuresToComplete.size)

assertEquals(2, futuresToComplete[0].numberOfDependents) // 2 dependants of touppercase1
assertEquals(1, futuresToComplete[1].numberOfDependents) // 1 dependant of touppercase2

assertEquals(2, futuresToComplete[2].numberOfDependents) // 2 dependants of TOLOWERCASE1
assertEquals(1, futuresToComplete[3].numberOfDependents) // 1 dependant of TOLOWERCASE2

registry.dispatchAll()
assertFalse(registry.onDispatchFuturesHandled())

Thread.sleep(500)
Expand Down