Revert throwing exception on missing directive wiring #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
force-pushed
the
directive_wiring
branch
from
f2cb38a to
59f2aa0
Compare
There are use cases when directives could be just informational (e.g. @deprecated). Instead of defining no-op directive wiring we should just ignore directives without wiring.
dariuszkuc
force-pushed
the
directive_wiring
branch
from
59f2aa0 to
0a30208
Compare
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
============================================
- Coverage 97.09% 97.07% -0.03%
+ Complexity 198 196 -2
============================================
Files 61 61
Lines 689 684 -5
Branches 121 120 -1
============================================
- Hits 669 664 -5
Misses 8 8
Partials 12 12
Continue to review full report at Codecov.
|
smyrick
reviewed
Jul 8, 2019
src/main/kotlin/com/expedia/graphql/directives/KotlinDirectiveWiringFactory.kt
Show resolved
Hide resolved
smyrick
approved these changes
Jul 8, 2019
tkruener
pushed a commit
to tkruener/graphql-kotlin
that referenced
this pull request
Jul 14, 2019
There are use cases when directives could be just informational (e.g. @deprecated). Instead of defining no-op directive wiring we should just ignore directives without wiring.
tkruener
pushed a commit
to tkruener/graphql-kotlin
that referenced
this pull request
Jul 14, 2019
There are use cases when directives could be just informational (e.g. @deprecated). Instead of defining no-op directive wiring we should just ignore directives without wiring.
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
There are use cases when directives could be just informational (e.g. @deprecated). Instead of defining no-op directive wiring we should just ignore directives without wiring.
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
There are use cases when directives could be just informational (e.g. @deprecated). Instead of defining no-op directive wiring we should just ignore directives without wiring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases when directives could be just informational (e.g. @deprecated). Instead of defining no-op directive wiring we should just ignore directives without wiring.