Add docs for new schema generator feature #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new features in ExpediaGroup#593 that we did not document
dariuszkuc
reviewed
Feb 3, 2020
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| id: evolving-schema | |||
| title: Evolving Schema | |||
| id: deprecating-schema | |||
There was a problem hiding this comment.
lets keep it as more generic evolving schema and add notes about adding new fields etc
There was a problem hiding this comment.
I was mainly doing this to help the sidebar be a little more clear. Right now it is not super descriptive for what is there.
Do you think we can just include this all on one page?
There was a problem hiding this comment.
The only info in the topic right now is on deprecating schema elements, so I'd recomment the title: Deprecating Schema Elements.
If or when you talk about other ways to evolve the schema or its elements, I'd change to something like Evolving Schema.
Just my two cents.
dariuszkuc
approved these changes
Feb 7, 2020
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Added new features in ExpediaGroup#593 that we did not document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update docs with new page describing the features
🔗 Related Issues
Added new features in #593 that we did not document