Add federation directives if not defined #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the extends directive is always used in federation on the Query object we should always have the directive definition in the schema. However it may already be added if the generated schema uses it, so only add the definition if it is not yet defined
smyrick
added
type: bug
smyrick
commented
May 11, 2020
| ) on FIELD_DEFINITION | ENUM_VALUE | ||
|
|
||
| "Marks target object as extending part of the federated schema" | ||
| directive @extends on OBJECT | INTERFACE |
There was a problem hiding this comment.
Before my fix, when I set includeDirectives = true below, this definition was not there
dariuszkuc
reviewed
May 12, 2020
...eration/src/main/kotlin/com/expediagroup/graphql/federation/FederatedSchemaGeneratorHooks.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
approved these changes
May 12, 2020
smyrick
changed the title
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Add extends directive if not defined Since the extends directive is always used in federation on the Query object we should always have the directive definition in the schema. However it may already be added if the generated schema uses it, so only add the definition if it is not yet defined * Add all directive definitions even if not used Co-authored-by: Shane Myrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This has now been changed to add all the federation directives if they are not defined.
Since the extends directive is always used in federation on the Query object we should always have the directive definition in the schema. However it may already be added if the generated schema uses it, so only add the definition if it is not yet defined
The schema we generate today will still work on the server, it just fails if you happen to run through the generated SDL through the Apollo CLI or Gateway.
🔗 Related Issues
N\A