Skip to content

Add maybe unused to variables in assert #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2022
Merged

Add maybe unused to variables in assert #479

merged 2 commits into from
Apr 29, 2022

Conversation

@jorgensd
Copy link
Member

@jorgensd jorgensd commented Apr 29, 2022

No description provided.

@jorgensd jorgensd requested a review from mscroggs April 29, 2022 12:42
@garth-wells
Copy link
Member

garth-wells commented Apr 29, 2022

I think it's better to put the expression directly in the assertion.

@jorgensd
Copy link
Member Author

jorgensd commented Apr 29, 2022

I think it's better to put the expression directly in the assertion.

Fixed

@mscroggs mscroggs merged commit 79a3b86 into main Apr 29, 2022
@mscroggs mscroggs deleted the dokken/maybe-unused branch April 29, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscroggs mscroggs Awaiting requested review from mscroggs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jorgensd @garth-wells @mscroggs