Use mdspan in polyset #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The runtime is compared to main (after the col->row) transition? |
Contributor
Author
Yes, but would be good for more people to check, if you have time. |
mscroggs
reviewed
May 24, 2022
mscroggs
reviewed
May 24, 2022
| #include <numeric> | ||
| #include <array> | ||
| #include <tuple> // std::apply | ||
| #include <utility> // std::pair |
Member
There was a problem hiding this comment.
Looks like a lot of these includes are repeated
Member
There was a problem hiding this comment.
I think these are automatically generated, so I wouldn't bother. (the file has more 5k lines of code)
Same for the other comment.
Contributor
Author
There was a problem hiding this comment.
Yes, it is due to the autogeneration of the single-header file
Contributor
Author
|
I've now done a few timing tests from Python, and there is a reasonable speedup with mdspan, for higher order cells. Not huge, but from 1.1x to 2x, generally. I think this is worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an implementation of
std::mdspanfor internal use only. In theory,std::mdspanwill be part of the C++23 standard, so in the future we can switch to it.tabulate_*functions (timed 10^6 point evaluations on P3 tets, runs 3x faster than xtensor with all optimisations on).polyset.cpp