Windows: make runtime dependency install optional #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundling dependencies is not desirable in a conda package, where packaging already handles this, plus it happens to be throwing an error because blas/lapack DLLs aren't found by cmake (their DIRECTORIES aren't specified).
I believe this was the only change I needed to get Windows builds to work on conda-forge: conda-forge/fenics-basix-feedstock#18
I'm not sure what the default should be, but I'd guess it should be OFF by default. I left the default behavior unchanged in this PR.
FWIW, the default vs2019 compiler failed with:
but this went away after upgrading to vs2022. In case anybody in the future reports a similar error, their compiler might be outdated.