Skip to content

Conversation

@minrk
Copy link
Contributor

@minrk minrk commented May 2, 2024

Bundling dependencies is not desirable in a conda package, where packaging already handles this, plus it happens to be throwing an error because blas/lapack DLLs aren't found by cmake (their DIRECTORIES aren't specified).

I believe this was the only change I needed to get Windows builds to work on conda-forge: conda-forge/fenics-basix-feedstock#18

I'm not sure what the default should be, but I'd guess it should be OFF by default. I left the default behavior unchanged in this PR.

FWIW, the default vs2019 compiler failed with:

D:\bld\fenics-basix-meta_1714546306829\work\cpp\basix\mdspan.hpp(3847,15): error C2672: 'std::experimental::detail::get_actual_static_padding_value': no matching overloaded function found [D:\bld\fenics-basix-meta_1714546306829\work\cpp\build\basix.vcxproj]
D:\bld\fenics-basix-meta_1714546306829\work\cpp\basix\mdspan.hpp(3849): message : see reference to class template instantiation 'std::experimental::detail::static_array_type_for_padded_extent<_PaddingValue,_Extents,_ExtentToPadIdx,_Rank,Enabled>' being compiled [D:\bld\fenics-basix-meta_1714546306829\work\cpp\build\basix.vcxproj]

but this went away after upgrading to vs2022. In case anybody in the future reports a similar error, their compiler might be outdated.

not desirable on conda, where packaging already handles this
@jhale jhale added this pull request to the merge queue May 6, 2024
@jhale
Copy link
Member

jhale commented May 6, 2024

Thanks, good news - I think we'll stick with supporting VS2022.

1 similar comment
@jhale
Copy link
Member

jhale commented May 6, 2024

Thanks, good news - I think we'll stick with supporting VS2022.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@minrk
Copy link
Contributor Author

minrk commented May 6, 2024

Maybe an informative error (or at least warning) if an older version is detected is a good idea?

@jhale jhale added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@jhale jhale enabled auto-merge May 6, 2024 08:43
@jhale jhale added this pull request to the merge queue May 6, 2024
Merged via the queue into FEniCS:main with commit 8818981 May 6, 2024
@minrk minrk deleted the windows-conda branch May 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants