Fix tolerances for determining DOF transformation type and add test #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
force-pushed
the
garth/basix-eps-fix
branch
from
1a39ff4 to
f9867c9
Compare
mscroggs
approved these changes
Nov 18, 2024
Co-authored-by: Matthew Scroggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for determining the DOF transformation type was failing for float32 at higher-orders for Lagrange elements. This PR relaxes a tolerance. It is somewhat arbitrary, but does seem to work.
Also makes more use of the BLAS GEMM wrappers to dramatically improve performance at high orders.
Resolves #874.