Expose and enforce compile time configuration of mdspan #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnellerhase
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
basixas a third-party library within aC++23compliant project the include ofmdspanwill trigger a default use of the bracket operator[], howeverbasixcurrently relies on parentheses based element access and thus compilation is not possible (especially due to presence ofmdspanbased computations in thebasixheaders).This (re-)adds the public config for the
mdspanheaders. Previously removed after a comment at #844 (comment).Since
basixdoes not install any headers during the python build, we do not need to (re-)add this in the Python config.