feat: update grading workflows #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
FidelusAleksander
commented
Apr 17, 2025
•
FidelusAleksander
commented
FidelusAleksander
force-pushed
the
grading-workflows
branch
from
61a9267 to
6d0c48e
Compare
chriswblake
reviewed
Apr 17, 2025
| file="src/static/app.js" | ||
| keyphrase='participant' | ||
| minimum_occurences=3 | ||
| found_occurences=$(grep -o "$keyphrase" "$file" | wc -l) | ||
| if [ "$found_occurences" -lt "$minimum_occurences" ]; then | ||
| checks=$(echo $checks | jq '.app_js.passed = false') | ||
| checks=$(echo $checks | jq '.app_js.message = "Please use Copilot to update the web application activity cards to show participant info."') | ||
| echo "::error::Please use Copilot to update the web application activity cards to show participant info." |
There was a problem hiding this comment.
Let's just leave this out
| template-vars: | | ||
| next_step_number=4 | ||
|
|
||
| - name: Update comment - step finished | ||
| if: ${{ !contains(steps.*.outcome, 'failure') }} |
There was a problem hiding this comment.
I think this if should be removed
| @@ -124,21 +101,16 @@ jobs: | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| COMMENT_BODY: ${{ steps.build-message-step-results.outputs.updated-text }} | |||
|
|
|||
| - name: Fail job if not all checks passed | |||
| if: steps.check-user-work.outputs.passed == 'false' | |||
There was a problem hiding this comment.
This needs to stay to fail the grading job. I think the if should switch to ${{ !contains(steps.*.outcome, 'failure') }}
There was a problem hiding this comment.
The check should be without the ! negation though, ${{ contains(steps.*.outcome, 'failure') }}
FidelusAleksander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.