Skip to content

Bugfix / Tweak: Coroutine server implementation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2023

Conversation

hyperschwartz
Copy link
Contributor

Description

Yet another iteration. This converts the entirety of the suite to use the coroutines implementation on the server side, creating a simpler syntax format. The previous solution was to use only the coroutine implementation for the route that returned a Flow, but Spring doesn't play nicely with multiple declarations of the same server.

Change Summary

  • Refactor the ObjectStoreGatewayServer to serve with the coroutine implementation from grpckt.
  • Refactor tests to interact with the fact that the server uses suspend functions.

@hyperschwartz hyperschwartz requested a review from a team May 24, 2023 21:33
@hyperschwartz hyperschwartz merged commit f35eff9 into main May 24, 2023
@hyperschwartz hyperschwartz deleted the hyperschwartz/convert-all-to-coroutine-handler branch May 24, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants