Skip to content
This repository was archived by the owner on Nov 19, 2018. It is now read-only.

changed react transition group version and updated gallery component #202

Conversation

shivgarg5676
Copy link
Contributor

No description provided.

@rnicholus
Copy link
Member

I'm unable to find time to test this, but would like to merge. Please confirm you've tested in both React v16 and v15. Thanks for all of your work on this!

@shivgarg5676
Copy link
Contributor Author

shivgarg5676 commented Jul 22, 2018

I have checked only on react v15.4.2 as it was in dev dependencies. All the test cases are getting passed and i did manual test as well. I will do a quick sanity on react v16. I will comment back when done

@shivgarg5676
Copy link
Contributor Author

As this package has been deprecated and is moved to react-dom/test-utils. We may need to update our entire test suite to run unit tests on react 16.
As I am a newbie, please guide how to test for react 16.

@rnicholus
Copy link
Member

I’m not certain this is absolutely needed, but if you want to upgrade the test suite and are running into a specific issue, let me know what the issue is so I can advise.

@shivgarg5676
Copy link
Contributor Author

shivgarg5676 commented Jul 22, 2018

Please guide how to test for react 16. I have tested by importing to my project and tested manually it is working but i am unable to run test suite using react 16.

I tried as follow but failed.

  1. Upgraded react and react-dom version to 16.4.1
  2. run npm install
  3. run test suite.

I am getting following error
Error: Cannot find module "react-dom/lib/ReactTestUtils" as this package has been moved to react-dom.

image

I have read here and there and people say that you need to import react-test-utils from react-dom/test-utils.

enzymejs/enzyme#684

@rnicholus
Copy link
Member

I have read here and there and people say that you need to import react-test-utils from react-dom/test-utils.

That sounds like a good place to start.

@shivgarg5676
Copy link
Contributor Author

shivgarg5676 commented Jul 31, 2018

I have tested on react 16. all test cases are getting passed on react-16. it is good to be merged
Should I commit new test suite working on react 16 or should we keep old test suite for react 15.

Sorry for the delay i got busy with few tasks at my office.

@rnicholus
Copy link
Member

rnicholus commented Aug 1, 2018

While I do want to maintain backwards compatibility w/ v14 & 15 to avoid a breaking change (and this is quite important), please commit your code that focuses on React 16 as I'd of course like to focus on that for the future.

@shivgarg5676
Copy link
Contributor Author

All of my code in this branch is backwards compatible and is working fine on both react v15 and v16. You can merge this branch, I will create a new branch with the updated test suite.

@shivgarg5676
Copy link
Contributor Author

#206

@shivgarg5676
Copy link
Contributor Author

@rnicholus can you merge this branch now?

@rnicholus rnicholus merged commit a5e9a7a into FineUploader:master Aug 9, 2018
@rnicholus
Copy link
Member

Merging now, and will release soon as v1.1.1. Thanks so much for all of your hard work on this!

@shivgarg5676 shivgarg5676 deleted the feature/react-transition-group-2.4 branch August 9, 2018 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants