-
Notifications
You must be signed in to change notification settings - Fork 124
changed react transition group version and updated gallery component #202
changed react transition group version and updated gallery component #202
Conversation
I'm unable to find time to test this, but would like to merge. Please confirm you've tested in both React v16 and v15. Thanks for all of your work on this! |
I have checked only on react v15.4.2 as it was in dev dependencies. All the test cases are getting passed and i did manual test as well. I will do a quick sanity on react v16. I will comment back when done |
As this package has been deprecated and is moved to react-dom/test-utils. We may need to update our entire test suite to run unit tests on react 16. |
I’m not certain this is absolutely needed, but if you want to upgrade the test suite and are running into a specific issue, let me know what the issue is so I can advise. |
Please guide how to test for react 16. I have tested by importing to my project and tested manually it is working but i am unable to run test suite using react 16. I tried as follow but failed.
I am getting following error I have read here and there and people say that you need to import react-test-utils from react-dom/test-utils. |
That sounds like a good place to start. |
I have tested on react 16. all test cases are getting passed on react-16. it is good to be merged Sorry for the delay i got busy with few tasks at my office. |
While I do want to maintain backwards compatibility w/ v14 & 15 to avoid a breaking change (and this is quite important), please commit your code that focuses on React 16 as I'd of course like to focus on that for the future. |
All of my code in this branch is backwards compatible and is working fine on both react v15 and v16. You can merge this branch, I will create a new branch with the updated test suite. |
@rnicholus can you merge this branch now? |
Merging now, and will release soon as v1.1.1. Thanks so much for all of your hard work on this! |
No description provided.