feat: support flutter_svg 2.0.0 #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcdsmao
force-pushed
the
flutter-svg-2.0
branch
from
f39ae47 to
a68e131
Compare
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 20 20
Lines 693 693
=======================================
Hits 681 681
Misses 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@lcdsmao Thank you. |
2 tasks
|
Do you have any timeline to merge and publish (to pub.dev) this PR? |
|
Sorry, I merged via Github App accidentally. |
|
@wasabeef Hello. This PR led to the fact that my generation broke. It generates a colorFilter no matter what version of flutter_svg I have. Such changes should be made in major versions. Now I have to update flutter_svg in all my packages. |
|
Sorry for the lack of explanation. |
Closed
2 tasks
ankiimation
pushed a commit
to ankiimation/flutter_gen
that referenced
this pull request
Dec 1, 2023
* feat: support flutter_svg 2.0.0 * feat: add lint ignore * chore: update example pubspec * chore: build runner exec result * test: update test resource with svg 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #<issue_number_goes_here> 🎯
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run unit:test)melos run formatto automatically apply formatting)