Support Lottie #70
Closed
Support Lottie #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be better to check if any json file contains the keys mentioned here: https://github.com/airbnb/lottie-web/blob/master/docs/json/animation.json |
nova8yte
added a commit
to nova8yte/flutter_gen
that referenced
this pull request
Aug 27, 2022
* dropped support for '*_lottie.json' per FlutterGen#70 PR * include root path for tests * update example
Closed
Merged
wasabeef
added a commit
that referenced
this pull request
Sep 28, 2022
* Add lottie integration * example & test asset * auto strip "lottie" from final asset var name * Update README.md * Update lottie integration * dropped support for '*_lottie.json' per #70 PR * include root path for tests * update example * set: min lottie version * rename resourcesPath for better code readability * fix: version must be equals or more than 4.4.0 * fix merge * support semver * change custom semver to pub_sem_ver * chore: add some usecases files * refactor: change to named constructor * test: add wrong test case Co-authored-by: Alexandra Kovaleva <[email protected]>
|
@HiroyukiTamura |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Support lottie.
Related: #47
https://github.com/HiroyukTamura/flutter_gen/blob/8175f15960733d5bd99ee694727027baa9756a59/lib/src/settings/asset_type.dart#L53-L54
What is the value of this and can you measure success?
Pass tests.