Skip to content

feat: Pass optional stats config to getStats().toJson() #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2019
Merged

feat: Pass optional stats config to getStats().toJson() #31

merged 4 commits into from
Jul 10, 2019

Conversation

evocateur
Copy link
Contributor

@evocateur evocateur commented Oct 21, 2018

I figured if one is passing custom stats config, it really doesn't make sense to automatically filter only assetsByChunkName. Of course, you can pass both options explicitly and the result will still be filtered.

I also synchronized some docs, fixed a typo, and made the build work with Node v10 and upgraded webpack-cli.

  • Add tests
  • Add docs

This fixes #18

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic @evocateur !

I've got one suggested code change. And, once the documentation in the code comments + README.md is updated I'm looking forward to do a new release!

(If you're too strapped for time to catch up the docs let me know, and I'll see if I have a moment for it. I'm already planning on a doing a big release for inspectpack with a new, dedicated DuplicatesPlugin, so my head's actually in the webpack game this week...)

@evocateur
Copy link
Contributor Author

Thanks for mentioning inspectpack, digging through its code helped me realize my stats defaults were too broad. Been trying to migrate a Webpack v3 build system to v4 at work, and wanted to use this handy plugin to do a bunch of fancy serialization (without having to redirect stdout to a file, etc).

@ryan-roemer ryan-roemer merged commit 960d905 into FormidableLabs:master Jul 10, 2019
@ryan-roemer
Copy link
Member

ryan-roemer commented Jul 10, 2019

Hi @evocateur !

I was randomly checking something here and wondering why this PR got totally dropped on my end, then looked at the date and realized I was still in recent newborn baby mode 👶

At any rate, got this cleaned up, merged, and released (as [email protected]) before a year elapsed... 😂

Thanks and let me know if you hit any issues with the new feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to set toJson options
2 participants