Fix: Ensure correct keytar migration on snap and improve documentation #2474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I double checked everything and am confident so far, that we can ship this. :) |
bengotow
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was not able to get the electron
safeStoragefeature running within snap without connecting it to the hostpassword-manager-service, I feel, that this is the next best solution:sudo snap connect mailspring:password-manager-servicecommand.I need to do some more tests especially if the migration properly works in all cases within snap and how the error message UI looks on other operating systems. But I hope, that we can release the 1.12 version with these changes.