On ExceptionController getExceptionMessage() fallback to error #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the status code is not recognized
Controller/ExceptionController.php
Outdated
Member
There was a problem hiding this comment.
why do you assign this var before the if statement
Contributor
Author
There was a problem hiding this comment.
no good reason, already changed it
lsmith77
added a commit
that referenced
this pull request
Jan 6, 2014
…-fallback-msg On ExceptionController getExceptionMessage() fallback to error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ExceptionController getExceptionMessage() fallback to 'error' if the status code is not recognized.
On getParameters() code I notice this:
I think is good idea to do the same on getExceptionMessage(), this PR is related with the code introduced on
#647