Add tests for pipe extension #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 99.73% (diff: 100%)@@ master #13 diff @@
==========================================
Files 93 93
Lines 759 759
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 732 757 +25
+ Misses 27 2 -25
Partials 0 0
|
| @@ -20,7 +20,7 @@ extension R { | |||
|
|
|||
| */ | |||
|
|
|||
| public class func find<A, B: SequenceType where A == B.Generator.Element>(predicate: (A) -> Bool, in sequence: B) -> A? { | |||
| private class func find<A>(predicate: (A) -> Bool, in sequence: [A]) -> A? { | |||
There was a problem hiding this comment.
@TYRONEMICHAEL Why are we changing this to private?
There was a problem hiding this comment.
Also not sure why we have to change it to an array, maybe you can show me because those images should fail because of the ambiguity. I'm probably missing something somewhere
There was a problem hiding this comment.
Jammer man. This should be public. Nice pick up Smith.
| @@ -41,7 +41,7 @@ extension R { | |||
|
|
|||
| */ | |||
|
|
|||
| public class func find<A, B: SequenceType where A == B.Generator.Element>(predicate: (A) -> Bool) -> (in: B) -> A? { | |||
| public class func find<A>(predicate: (A) -> Bool) -> (in: [A]) -> A? { | |||
There was a problem hiding this comment.
Maybe we should consider using CollectionTypes rather than Sequences then?
| } | ||
|
|
||
| func testPipeOperatorShouldPipeMultipleFunctions() { | ||
| let pipe = testData |
There was a problem hiding this comment.
I really like this, looks good 👍
|
@JustinGuedes fixed this. So we should merge this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JustinGuedes I had to change the signature of find to take an array as opposed to a sequence type. I just could not get find to work as a curried function otherwise. Check pipe tests for an example. Maybe I am doing something wrong. Coverage will also be down until this is merged in.