Compatibility for Swift 5.0 + additions with tests #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap, aperture, apply, empty
leovido
changed the title
TYRONEMICHAEL
previously approved these changes
Sep 28, 2019
|
Nice work @kuriishu27. @JustinGuedes if you are happy please merge. |
Ramda/Extensions/aperture.swift
Outdated
|
|
||
| */ | ||
|
|
||
| public class func aperture(_ number: Int, _ value: [Int]) -> [[Int]] { |
There was a problem hiding this comment.
I added aperture in the other PR which has not been merged in yet. Added you as a reviewer. So there will be conflicts. We can get mine in, and then I can resolve conflicts on your branch.
There was a problem hiding this comment.
I noticed you added aperture as well after I pushed my changes. Thanks for adding me as a reviewer. I agree yours looks cleaner.
There was a problem hiding this comment.
I removed my aperture implementation and accepted your pull request with the other additions
tests were inheriting from XCTest instead of XCTestCase
add both, gt, gte, lt, lte and missing cases for append + updated README
TYRONEMICHAEL
approved these changes
Apr 7, 2020
| } | ||
| } | ||
|
|
||
| return newString |
There was a problem hiding this comment.
Look at all the other methods we have implemented. If it takes more than one input it has to be curried as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added empty and aperture with tests