Skip to content

fixes issue with config:cache issue #80 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

juliancc
Copy link
Contributor

This fixes a bug that causes artisan config:cache to not cache the values set in the .env for the config file of stream.

The original problem lies, that the register method was setting empty values.

Copy link
Contributor

@pterk pterk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juliancc
Copy link
Contributor Author

all good to merge @tbarbugli?

@pterk pterk merged commit 0379873 into GetStream:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants