Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Add drop shadow to separate bar button and body text #2573

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Add drop shadow to separate bar button and body text #2573

merged 2 commits into from
Jan 2, 2019

Conversation

maniramezan
Copy link
Contributor

A possible way to implement the issue mentioned in #2196

@maniramezan maniramezan added the 🎨 design Changes to the design of the app label Dec 30, 2018
@rnystrom
Copy link
Member

Mind posting a screenshot?

Sent with GitHawk

@maniramezan
Copy link
Contributor Author

maniramezan commented Dec 31, 2018 •
edited
Loading

Aw, sorry, forgot to add it. Here's how it looks:



And here's another one:

rnystrom
rnystrom suggested changes Jan 1, 2019
View reviewed changes
Copy link
Member

@rnystrom rnystrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I def think we need to do this, but the shadow in the screenshot is a little intense IMO. Any way to make it even smaller? Maybe playing w/ the other shadow properties?

Classes/Repository/RepositoryViewController.swift
buttonBarView.layer.shadowColor = UIColor.black.cgColor
buttonBarView.layer.shadowOpacity = 1
buttonBarView.layer.shadowPath = shadowPath.cgPath
buttonBarView.layer.shouldRasterize = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required, but since the view doesn't change, it helps to reduce shadow-drawing. Can omit it and re-add it if there was any performance issue

@maniramezan
Copy link
Contributor Author

Maybe reducing the shadowRadius to 2.0 which is 3.0 by default and changing the color to darkGray does the trick?

@rnystrom
Copy link
Member

rnystrom commented Jan 2, 2019

Ya lets give that a spin

Sent with GitHawk

@rnystrom rnystrom merged commit 51fb5fb into master Jan 2, 2019
@rnystrom rnystrom deleted the drop-shadow-separator branch January 2, 2019 15:30
@rnystrom rnystrom mentioned this pull request Jan 4, 2019
Closed
rnystrom added a commit that referenced this pull request Jan 4, 2019
@rnystrom
Revert "Add drop shadow to separate bar button and body text (#2573)"
7b0b45d 
This reverts commit 51fb5fb.
@rnystrom rnystrom mentioned this pull request Jan 4, 2019
Merged
rnystrom added a commit that referenced this pull request Jan 4, 2019
@rnystrom
Revert "Add drop shadow to separate bar button and body text" (#2588)
f47571c 
* Revert "fix crash showing localized alert for partial migrations (#2585)"

This reverts commit beb22c6.

* Revert "Add drop shadow to separate bar button and body text (#2573)"

This reverts commit 51fb5fb.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rnystrom rnystrom rnystrom requested changes

Assignees
No one assigned
Labels
🎨 design Changes to the design of the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maniramezan @rnystrom