Skip to content

Improve tabs link support #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Improve tabs link support #3211

wants to merge 9 commits into from
+175 −135

Conversation

clairechabas
Copy link
Contributor

@clairechabas clairechabas commented May 5, 2025 •
edited
Loading

Reproducing headings hash links UX: show the hash link button on the left of tabs block when hovered. The URL hash will match the selected tab.

Move hash link button to its component for reusability and unifies its styles for all blocks for consistency.

Preview

Default width tabs
Screenshot 2025-05-05 at 11 45 00

Full width tabs
Screenshot 2025-05-05 at 11 54 08

@linear Linear
Copy link

linear bot commented May 5, 2025

RND-6959 Add support for tabs links in GBO

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d30ebfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited
Loading

Summary of the deployments:

Version 1

Version URL Status
Latest commit https://c765dfbe.gitbook-open.pages.dev ✅
PR https://pr3211.gitbook-open.pages.dev ✅

Version 2

Version URL Status
Vercel https://gitbook-v2-41gk1bw9l-gitbook.vercel.app ✅
Cloudflare https://327f0537-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 2v 2c
GitBook https://c765dfbe.gitbook-open.pages.dev/docs.gitbook.com https://gitbook-v2-41gk1bw9l-gitbook.vercel.app/url/docs.gitbook.com https://327f0537-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E https://c765dfbe.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-41gk1bw9l-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://327f0537-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link

argos-ci bot commented May 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ⚠️ Changes detected (Review) 4 changed May 5, 2025, 9:17 PM
customers-v2 (Inspect) ⚠️ Changes detected (Review) 4 changed May 5, 2025, 9:18 PM
default (Inspect) ⚠️ Changes detected (Review) 4 changed May 5, 2025, 9:20 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 3 changed May 5, 2025, 9:20 PM

@clairechabas
Merge branch 'main' into claire/rnd-6959-add-support-for-tabs-links-i…
73e57b5 
…n-gbo

* main:
  Use absolute URLs in sitemap.xml when pointing to sitemap-pages.xml (#3210)
clairechabas
clairechabas commented May 5, 2025
View reviewed changes
packages/gitbook/src/components/DocumentView/Tabs/DynamicTabs.tsx
block={block}
className={tcls('absolute', 'left-6')}
/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewer: the code below was not touched, the highlighted changes below are due to wrapping the code in this new div container above.

@clairechabas clairechabas marked this pull request as draft May 5, 2025 09:20
@clairechabas clairechabas marked this pull request as ready for review May 5, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clairechabas