Fix missing license files in the released gix-testtools crate #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, the massive changelog isn't bloating the crate.
Byron
approved these changes
Jun 22, 2024
|
Wonderful! Thank you. |
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Sep 11, 2024
This removes the `gix-ignore` and `gix-index` direct dependencies of `gix-testtools`, by having `gix_testtools` use them through `gix-worktree`, accessing `gix_worktree::ignore` for `gix_ignore` and `gix_worktree::index` for `gix_index`. The rationale is that various other gix-* dependencies were used this way already, and also that this specific change appears to have been planned, based on the TODO comment in ddaacda (GitoxideLabs#1413).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents of
tests/tools/are released as https://crates.io/crates/gix-testtools, so license-file symlinks are needed to ensure the license texts are distributed.