Skip to content

Rotate and Delete from the ground up #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Rotate and Delete from the ground up #660

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bb65179
setup rotatable Rotation (to fix #613 - try number 2 after PR #657)
hchiam Mar 19, 2025
5a52cca
create a visbug-delete element
hchiam Mar 19, 2025
30f5f6a
tweak styling of rotation and delete elements
hchiam Mar 19, 2025
8c17558
rotate rotation icon with rotation degrees
hchiam Mar 19, 2025
50bfb7d
fix the posiitioning of the handle during rotation
hchiam Mar 19, 2025
ba7a377
selectable has both delete and rotation, and delete deletes rotation …
hchiam Mar 19, 2025
3429524
avoid annoying hover bug when rotating by making rotation handle stay…
hchiam Mar 19, 2025
cc565d9
avoid Uncaught DOMException: HTMLElement.showPopover: Element is not …
hchiam Mar 19, 2025
3080ee7
rotation handle stays centered on cursor
hchiam Mar 19, 2025
217063c
show a line to the rotation handle during rotation
hchiam Mar 19, 2025
4e53191
fixed rotatiion "flip" at certain angles
hchiam Mar 19, 2025
256dc76
you can continue rotating from where you last let go
hchiam Mar 19, 2025
4bd3fa7
revert/cleanup
hchiam Mar 19, 2025
5e51cdf
import Delete more consistently
hchiam Apr 21, 2025
991e155
fix pressing delete on the keyboard also now deletes associated rotat…
hchiam Apr 21, 2025
5a0229b
Rotation changes display inline to inline-block - should be safe sinc…
hchiam Apr 21, 2025
9e97ba6
animateViewTransition (with fallback)
hchiam Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rotate rotation icon with rotation degrees
  • Loading branch information
@hchiam
hchiam committed Mar 19, 2025
commit 8c175588a00e4de1a7b822be606ea8f44af7df4c
6 changes: 5 additions & 1 deletion app/components/selection/rotation.element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ export class Rotation extends HTMLElement {
this.currentAngle += rotation
this.startAngle = angle

this.targetElement.style.transform = `rotate(${this.currentAngle * (180 / Math.PI)}deg)`
const rotationDegrees = this.currentAngle * (180 / Math.PI)
this.targetElement.style.transform = `rotate(${rotationDegrees}deg)`

const handle = this.$shadow.querySelector('.rotation-handle')
handle.style.transform = `rotate(${rotationDegrees}deg)`
}

const onMouseUp = () => {
Expand Down