Fix multiple issues with Go panic captures #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Capture would stop at "created by function" lines - Capture was expecting two blank lines between goroutines, whereas goroutines only have one blank line between them. - Capture would stop when given a panic started by a signal (like a nil panic) - Frame matching was only checking for an identifier character followed by an opening paren. Updated to be more precise. - The substring "panic:" could start a Go capture even in the middle of a word. This may still fail in cases where the panic includes a runtime stack (the Go runtime itself crashes), but Russ and others deemed this a far enough edge case to not dwell on.
|
@igorpeshansky PTAL |
igorpeshansky
approved these changes
Oct 25, 2017
|
@qingling128, mind tagging and releasing the gem? |
|
🎉 🎉 |
|
Sure thing! Tagged and released as v0.0.8 |
Closed
zombiezen
added a commit
to zombiezen/k8s-stackdriver
that referenced
this pull request
Jan 11, 2018
Fixes Go panic parsing bugs addressed in GoogleCloudPlatform/fluent-plugin-detect-exceptions#18
zombiezen
added a commit
to zombiezen/k8s-stackdriver
that referenced
this pull request
Jan 12, 2018
Fixes Go panic parsing bugs addressed in GoogleCloudPlatform/fluent-plugin-detect-exceptions#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panic:could start a Go capture even in the middle of a word.This may still fail in cases where the panic includes a runtime stack (the Go runtime itself crashes), but Russ and others deemed this a far enough edge case to not dwell on.