Skip to content

Checkstyle fixes for async-rest sample. #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2016
Merged

Checkstyle fixes for async-rest sample. #119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a53f0cb
Apply shared checkstyles to all samples.
tswast Mar 16, 2016
0f33dac
Checkstyle fixes for async-rest sample.
tswast Mar 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Apply shared checkstyles to all samples. 
We use git submodules, so to check out all the code for
`java-docs-samples`, we need to clone with the `--recursive` flag.

```
git clone --recursive [email protected]:GoogleCloudPlatform/java-docs-samples.git
```

To check out the directory in an already-cloned repo, run:

```
git submodule update --init --recursive
```
  • Loading branch information
@tswast
tswast committed Mar 16, 2016
commit a53f0cb4bab1de8b3fc12c775857e47d50b883f2
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "java-repo-tools"]
path = java-repo-tools
url = https://github.com/GoogleCloudPlatform/java-repo-tools.git
201 changes: 0 additions & 201 deletions google-checks.xml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions java-repo-tools
Open in desktop
Submodule java-repo-tools added at 5c9a31
55 changes: 8 additions & 47 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,17 @@
<artifactId>doc-samples</artifactId>
<packaging>pom</packaging>

<!-- Parent POM defines common plugins and properties. -->
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.0.0</version>
<relativePath>java-repo-tools</relativePath>
</parent>

<properties>
<appengine.sdk.version>1.9.32</appengine.sdk.version>
<appengine.app.version>1</appengine.app.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.http.version>1.19.0</project.http.version>
<project.oauth.version>1.19.0</project.oauth.version>
<maven.compiler.target>1.7</maven.compiler.target>
Expand Down Expand Up @@ -51,52 +58,6 @@
<module>unittests</module>
</modules>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<configuration>
<configLocation>google-checks.xml</configLocation>
<consoleOutput>true</consoleOutput>
<failOnViolation>true</failOnViolation>
<failsOnError>true</failsOnError>
</configuration>
<executions>
<execution><goals><goal>check</goal></goals></execution>
</executions>
</plugin>
<plugin>
<groupId>org.eluder.coveralls</groupId>
<artifactId>coveralls-maven-plugin</artifactId>
<version>3.1.0</version>
<configuration>
<coberturaReports>
<coberturaReport>${basedir}/target/coverage.xml</coberturaReport>
</coberturaReports>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>cobertura-maven-plugin</artifactId>
<version>2.6</version>
<configuration>
<outputDirectory>${basedir}/target</outputDirectory>
<formats>
<format>xml</format>
<format>html</format>
</formats>
<format>xml</format>
<maxmem>256m</maxmem>
<!-- aggregated reports for multi-module projects -->
<aggregate>true</aggregate>
</configuration>
</plugin>
</plugins>

</build>

<dependencyManagement>
<dependencies>
<!-- Compile/runtime dependencies -->
Expand Down