Skip to content

Add WordCount template sample #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Add WordCount template sample #1469

merged 1 commit into from
Jun 18, 2019

Conversation

davidcavazos
Copy link
Contributor

Code sample for the Creating templates page.

@davidcavazos davidcavazos requested a review from a team June 13, 2019 22:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
lesv
lesv previously requested changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

davidcavazos
davidcavazos commented Jun 14, 2019
View reviewed changes
Copy link
Contributor Author

@davidcavazos davidcavazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded a new version.

  • Updated README with more thorough instructions
  • Simplified and updated pom file

@davidcavazos davidcavazos dismissed lesv’s stale review June 17, 2019 16:35

Addressed comments

@davidcavazos davidcavazos requested a review from lesv June 17, 2019 20:41
@davidcavazos davidcavazos merged commit a723c47 into GoogleCloudPlatform:master Jun 18, 2019
@davidcavazos davidcavazos deleted the templates branch June 19, 2019 17:50
@davidcavazos davidcavazos restored the templates branch June 19, 2019 17:50
@davidcavazos davidcavazos deleted the templates branch June 19, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidcavazos @lesv @googlebot