Skip to content

[Endpoints Framework] Updating migration sample for endpoints framework plugin GA #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 25, 2017
Merged

[Endpoints Framework] Updating migration sample for endpoints framework plugin GA #676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
64f067f
Added additional information on discovery doc generation to README.md
May 23, 2017
0e2f3cd
Updated endpoints framework plugin versions and added hostname param
May 23, 2017
09417bd
Changed wording for hostname parameter
May 24, 2017
8c958ca
Added link-to-line instead of file.
May 24, 2017
6f17fc4
s/GOOGLE_CLOUD_PROJECT/YOUR-PROJECT-ID/
May 24, 2017
1047e70
Changing version number to + for build.gradle
May 24, 2017
ab01ba7
Merge branch 'master' into update-endpoints-migration-sample
frankyn May 24, 2017
fecf308
endpoints-framework-tools not needed only endpoints-framework
May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated endpoints framework plugin versions and added hostname param
  • Loading branch information
Frank Natividad committed May 23, 2017
commit 0e2f3cd72572c76004720026029859cccc2559a3
9 changes: 5 additions & 4 deletions appengine/endpoints-frameworks-v2/migration-example/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ buildscript { // Configuration for building
}
dependencies {
// App Engine Gradle plugin
classpath 'com.google.cloud.tools:appengine-gradle-plugin:1.3.0'
classpath 'com.google.cloud.tools:appengine-gradle-plugin:1.3.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using + w/ Gradle will get the latest.


// Endpoints Frameworks Gradle plugin
classpath 'com.google.cloud.tools:endpoints-framework-gradle-plugin:1.0.0-beta9'
classpath 'com.google.cloud.tools:endpoints-framework-gradle-plugin:1.0.0'
}
}
// [END buildscript]
Expand Down Expand Up @@ -71,11 +71,12 @@ appengine { // App Engine tasks configuration
}
}

/* [START endpoints-server]
// [START endpoints-server]
endpointsServer {
// Endpoints Framework Plugin server-side configuration
hostname = "GOOGLE_CLOUD_PROJECT.appspot.com"
}
[END endpoints-server] */
// [END endpoints-server]

group = 'com.example.helloendpoints' // Generated output GroupId
version = '1' // Version in generated output
Expand Down
3 changes: 2 additions & 1 deletion appengine/endpoints-frameworks-v2/migration-example/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.tools</groupId>
<artifactId>endpoints-framework-maven-plugin</artifactId>
<version>1.0.0-beta5</version>
<version>1.0.0</version>
<configuration>
<!-- plugin configuration -->
<hostname>GOOGLE_CLOUD_PROJECT.appspot.com</hostname>
</configuration>
</plugin>
<!-- [END endpoints-frameworks-plugin] -->
Expand Down