-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Feature/update hibernate 6 #7381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update hibernate 6 #7381
Conversation
@@ -6,13 +6,13 @@ | |||
<modelVersion>4.0.0</modelVersion> | |||
|
|||
<properties> | |||
<maven.compiler.target>1.8</maven.compiler.target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add some context in the PR description around why we're upgrading this to Java 11, and why we're removing the spanner dependency? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hibernate 6 requires Java 11, see here.
Also, spanner dialect has been moved inside hibernate package, i.e., org.hibernate.dialect.SpannerDialect
.
Hi @kweinmeister, do we still need this PR? |
Version update is needed for new features
@JoeWang1127 Has this been tested since there is no automated tests? |
Hi @averikitsch, I tested the sample on my local environment and it worked as expected. This is the output, you can find the hibernate version and dialect are updated
|
Thank you @JoeWang1127 |
Fixes #7318
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only