Skip to content

chore: remove bq data transfer samples (moved) #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Conversation

danoscarmike
Copy link
Contributor

@danoscarmike danoscarmike commented Aug 28, 2020

Moving to googleapis/python-bigquery-datatransfer

Do not merge until googleapis#38 is merged (and cloud site is redirected).

@danoscarmike danoscarmike added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 28, 2020
@danoscarmike danoscarmike requested a review from shollyman August 28, 2020 19:55
@danoscarmike danoscarmike requested a review from a team as a code owner August 28, 2020 19:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 29, 2020
@danoscarmike
Copy link
Contributor Author

cc/ @plamut for vis

@plamut
Copy link
Contributor

plamut commented Sep 5, 2020

@danoscarmike This is great, just when I wanted to start moving BQ datatransfer to microgenerator myself. Good to see that the samples are already being moved!

@danoscarmike
Copy link
Contributor Author

googleapis#38 is merged. Waiting on internal CL to land to divert cloud site to new location.

@danoscarmike
Copy link
Contributor Author

Cloud site redirect is submitted/complete.

@danoscarmike danoscarmike removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 16, 2020
@danoscarmike danoscarmike assigned plamut and unassigned crwilcox Sep 16, 2020
@plamut
Copy link
Contributor

plamut commented Sep 16, 2020

LGTM, I think we can merge this (I don't have review/merge permissions on this repo, though).

@danoscarmike danoscarmike merged commit 4e21a2a into master Sep 21, 2020
@danoscarmike danoscarmike deleted the remove-bqdt branch September 21, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants