Skip to content

Add Cython utils needed for zero-copy import and export. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2021

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Apr 22, 2021

I'd like to add a few tests for this code, but it may be sufficient if grblas tests pass.

eriknw added a commit to eriknw/grblas that referenced this pull request Apr 22, 2021
This currently works with the PR: GraphBLAS/python-suitesparse-graphblas#9

Of course, this PR won't pass until we have package on conda-forge for `suitesparse-graphblas`
@eriknw
Copy link
Member Author

eriknw commented Apr 23, 2021

This allows grblas to be a pure Python package: python-graphblas/python-graphblas#84

I still want to move some initialization logic for calling GxB_init to suitesparse_graphblas so that pygraphblas and grblas don't both try to initialize GraphBLAS.

@michelp
Copy link
Member

michelp commented Apr 23, 2021 via email

@eriknw
Copy link
Member Author

eriknw commented Apr 23, 2021

Whoops, I just saw your comment @michelp! Yeah, each library could check using such a mechanism. I defined initialize and is_initialized functions in ssgb (my current abbreviation for this package) instead. Thanks for the trick!

initialize allows one to choose between using numpy's memory allocators or not. I'm curious to do benchmarking to see if it makes a difference.

I think this is ready for final review and merging.

@jim22k jim22k merged commit 09eb560 into GraphBLAS:main Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants