-
-
Notifications
You must be signed in to change notification settings - Fork 776
Generalize layers as merge nodes to enable adjustment layers #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
58dd67a
WIP, backward traversal issues
adamgerhant 7cbff5d
Fix some tool issues
0HyperCube 54f0b0d
Remove debugging
Keavon 51c61ba
Change some indices
0HyperCube c290cbd
WIP: new artboard node
adamgerhant e1498f8
WIP: add artboard node
adamgerhant 077a1ba
WIP: Artboard node and create_artboard
adamgerhant 769f3f4
WIP: Artboard node implementation complete
adamgerhant 7be8bcb
WIP: Artboards input for output node
adamgerhant 6901f49
Complete Artboard node
adamgerhant 367199e
Generalize LayerNodeIdentifier, monitor_nodes support for Artboard n…
adamgerhant 7a649cc
Fix misaligned artboard click targets
Keavon c189af3
Generalize/clarify create_layer and insert_between
adamgerhant e9992a4
non-negative dimensions for resize_artboard
adamgerhant 9589d7f
Show artboards in layer panel
adamgerhant 221440f
Generalize create_layer for layer output node
adamgerhant 36df33b
Generalize delete_layer/delete_artboard to NodeGraphMessage::DeleteNo…
adamgerhant 431f20f
remove old primary_input function
adamgerhant abbda86
Vertical node visuals, remove is_layer function, rename Layer node to…
adamgerhant b150486
Fix demo artwork
adamgerhant f85bd44
Layer display context menu
adamgerhant 89cff28
Automatically select artboard, fix warnings
adamgerhant da66f57
Improvements to context menu and layer invariant enforcement
adamgerhant 4b7cac7
Remove display_as_layer and update load_structure
adamgerhant cc0bb44
Improve load_structure to show more layers, improve FlowIter, improve…
adamgerhant a66e61a
Clean up demo artwork using generalized layers
Keavon 9471ea0
Improve design of Layers panel and graph nodes
Keavon ab366cf
MoveSelectedLayersTo rewrite to support generalized layer nodes
adamgerhant 6ca4a5d
Include artboards in deepest_common_ancestor, fix resize_artboard/del…
adamgerhant 8a04bc8
MoveSelectedLayersTo adjustments
adamgerhant 43ae283
Sync non layer node visibility with metadata
adamgerhant a6a35aa
Include non layer nodes when moving/creating layer
adamgerhant 6c9d68b
Fix group layers and get_post_node_with_index
adamgerhant 52546ee
Include non layer nodes in UngroupSelectedLayers
adamgerhant c2395ef
GroupSelected for all selected nodes, UnGroupSelected position adjust…
adamgerhant 76ec270
Add grouping for layers in different folders
adamgerhant d96db73
Fix hidden layers
adamgerhant 18449a6
Prevent node from connecting to itself, fix undo automatic node inser…
adamgerhant ebd3f33
Fix undo CreateEmptyFolder, fix grouping nested layer nodes
adamgerhant 5409e27
Formatting
Keavon 650f6ea
Merge branch 'master' into adjustment-layers
Keavon 531136b
Remove test and check if node is layer from network
adamgerhant e7ee147
Fix undo group layers
adamgerhant febb8d0
Check off roadmap
Keavon f650566
MoveUpstreamSiblingsToChild adjustments
adamgerhant fa2cb39
Replace tabs with spaces, remove mut from argument
adamgerhant ceb3fde
Final code review pass
Keavon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check off roadmap
- Loading branch information
commit febb8d03386505056811cb1795d8bb5bfc3ca1f5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.