-
-
Notifications
You must be signed in to change notification settings - Fork 579
Node network subgraph editing #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons for Merge internal nodes
a050fa5
to
a9507c0
Compare
0a87bae
to
f3efcad
Compare
…deleting currently viewed node
…ws, tests, demo artwork
975b54d
to
48c975f
Compare
Keavon
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoo, what a herculean effort you've put in with this one! What a valuable addition to making the node graph so much more complete now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1172, closes #1765, and closes #1764. Discussion in this Discord thread.
Double-clicking nodes (except those based on proto nodes) enters their subgraph, replacing what's currently viewed in the node graph.
Todo
NodeInput::Network
. This allows multiple nodes to use the same import field, and enables creation of the "Imports" nodeOption<NodeId>
default node thatDocumentMetadata
will use to display/update/add layersIssues:
map_ids
)Deferred:
DocumentNodeDefinition
internal networksChange to consider: