Make noise generation resolution aware #1909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements footprint based noise generation. I originally intended to also fix the Mandelbrot node in this pr but it turns out that the node itself was never broken and it only stopped working due to an regression somewhere else which has since been fixed.
Changes:
The dimensions are new inferred from the footprint
The user can now choose if they want to constrain the noise
Alternatives considered
We could instead make the dimension parameter optional, which would eliminate the need for a transform node after the noise node. This might provide a nicer to use api and could be implemented in a follow-up pr.
We now only render what is visible on the screen and also support clipping to the viewport itself: